[ 
https://issues.apache.org/jira/browse/QPID-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290923#comment-13290923
 ] 

Keith Wall commented on QPID-3997:
----------------------------------

Hi Rob,

I'll rename #getAuthenticationManagerFor => getAuthenticationManagerFor.   On 
the testing front, when I wrote the code I was happy to rely on the fact that 
the system test (MultipleAuthenticationManagersTest) was already exercising the 
config parsing code.

On reflection, I think I would be better to add unit tests to 
ServerConfigurationTest to test the correct handling of 
defaultAuthenticationManager and portAuthenticationMappings config entries.  I 
take your point about the fact this code will go away soonish, but at least 
with the additional config unit test these will serve as a reminder to test the 
equivalent configuration abilities of the new code when it arrives.


                
> [Java Broker] Allow assignment of AuthenticationManager on a per-port basis
> ---------------------------------------------------------------------------
>
>                 Key: QPID-3997
>                 URL: https://issues.apache.org/jira/browse/QPID-3997
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>
> Currently we only allow for a single AuthenticationManager across all ports.  
> We should allow for separate ports to allow for different authentication 
> schemes.  Ideally we should also allow for different vhosts to be bound to 
> different ports and for different SASL mechanisms to be bound to different 
> authentication managers, but these steps should be covered by later JIRAs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to