----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5616/#review8714 -----------------------------------------------------------
Biggest complaint is the passing of connection id and *especially* created-by everywhere. Is there no way to make this less ugly? trunk/qpid/cpp/include/qpid/SessionId.h <https://reviews.apache.org/r/5616/#comment18388> Not convinced this is the ideal place for this... trunk/qpid/cpp/src/qpid/broker/Broker.h <https://reviews.apache.org/r/5616/#comment18387> How does createdBy differ from userId? trunk/qpid/cpp/src/qpid/broker/Exchange.cpp <https://reviews.apache.org/r/5616/#comment18389> The term 'closed' is not very transparent. In this context 'destroyed' might be best; 'deleted' is arguably when the exchange is removed from the registry. trunk/qpid/cpp/src/qpid/broker/Exchange.cpp <https://reviews.apache.org/r/5616/#comment18390> Probably not a big issue, but this is going to be done regardless of whether it gets logged. trunk/qpid/cpp/src/qpid/broker/Queue.cpp <https://reviews.apache.org/r/5616/#comment18392> Again this is done regardless of whether its needed; probably not a big issue but somehow less than ideal... trunk/qpid/cpp/src/qpid/broker/Queue.cpp <https://reviews.apache.org/r/5616/#comment18393> Again 'closed' isn't a terribly meaningful verb in the context of a queue. trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp <https://reviews.apache.org/r/5616/#comment18394> Ok, I think that answers my earlier question. I really dislike passing this 'created by' string through everywhere and I really don't like the name of the parameter. - Gordon Sim On June 27, 2012, 9:09 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5616/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 9:09 p.m.) > > > Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross. > > > Description > ------- > > This patch adds a new log category [Configuration] and publishes a bunch of > information at info level in the format: > [Configuration] <object> <event>, where <object> is one of Connection, > Session, Queue, Subscription, Exchange or Binding, and <event> is one of > created or closed with connection also getting a setUser. > The bulk of the patch involves passing the necessary strings down to the > object creators so that they can emit the log. > > > This addresses bug QPID-4079. > https://issues.apache.org/jira/browse/QPID-4079 > > > Diffs > ----- > > trunk/qpid/cpp/include/qpid/SessionId.h 1354515 > trunk/qpid/cpp/include/qpid/log/Statement.h 1354515 > trunk/qpid/cpp/src/qpid/SessionId.cpp 1354515 > trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/Broker.h 1354515 > trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/DirectExchange.h 1354515 > trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/Exchange.h 1354515 > trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h 1354515 > trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/FanOutExchange.h 1354515 > trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1354515 > trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/Queue.h 1354515 > trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/QueueRegistry.h 1354515 > trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1354515 > trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1354515 > trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1354515 > trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1354515 > trunk/qpid/cpp/src/qpid/log/Statement.cpp 1354515 > trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1354515 > trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1354515 > trunk/qpid/cpp/src/qpid/xml/XmlExchangePlugin.cpp 1354515 > > Diff: https://reviews.apache.org/r/5616/diff/ > > > Testing > ------- > > Passes cmake test and automake make check. > > > Thanks, > > Chug Rolke > >