----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6153/#review9500 -----------------------------------------------------------
Ship it! Ship It! - Gordon Sim On July 26, 2012, 4:04 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6153/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 4:04 p.m.) > > > Review request for qpid and Gordon Sim. > > > Description > ------- > > Fix test_failover_send_receive showing missing messages. With this fix, > ran with -DDURATION=2 overnight with no failures. > > - Primary, RemoteBackup: Only report "ready" once per remote backup. > - HaBroker: Put membership updates under mutex. > - ReplicatingSubscription: Check for backup missing messages at the front. > - ha_tests.py: Added assertion to test_priority_ring, verify primary > queue as expected. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/ha/HaBroker.h 1365832 > /trunk/qpid/cpp/src/qpid/ha/HaBroker.cpp 1365832 > /trunk/qpid/cpp/src/qpid/ha/Primary.cpp 1365832 > /trunk/qpid/cpp/src/qpid/ha/RemoteBackup.h 1365832 > /trunk/qpid/cpp/src/qpid/ha/RemoteBackup.cpp 1365832 > /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1365832 > /trunk/qpid/cpp/src/tests/ha_tests.py 1365832 > > Diff: https://reviews.apache.org/r/6153/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
