----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6838/#review10885 -----------------------------------------------------------
I don't particularly like having support for plugin specific options (i.e. options for one store plugin) hardcoded into the broker, but the current handling of store options is not great to begin with so I'm not against this patch. A more generic handling of permissions for options would be preferable longer term, but I could live with this as a short term measure. - Gordon Sim On Aug. 29, 2012, 7:54 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6838/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 7:54 p.m.) > > > Review request for qpid and Gordon Sim. > > > Description > ------- > > This patch adds Acl support for store file size/count similar to in-memory > queue size/message_count. > > > This addresses bug QPID-4268. > https://issues.apache.org/jira/browse/QPID-4268 > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1378685 > trunk/qpid/cpp/src/qpid/acl/AclValidator.cpp 1378685 > trunk/qpid/cpp/src/qpid/broker/AclModule.h 1378685 > trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1378685 > trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1378685 > trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1378685 > trunk/qpid/cpp/src/tests/acl.py 1378685 > > Diff: https://reviews.apache.org/r/6838/diff/ > > > Testing > ------- > > Acl limits exercised for new properties. General allow/deny tests work > similar to queue tests. > > > Thanks, > > Chug Rolke > >
