> On Oct. 12, 2012, 4:42 p.m., Steve Huston wrote: > > In ProtocolVersion.cpp should the use of the numbers 2 and 3 be replaced by > > the defined constants for them?
Yes! I'll make that change. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7563/#review12398 ----------------------------------------------------------- On Oct. 12, 2012, 4:36 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7563/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2012, 4:36 p.m.) > > > Review request for qpid. > > > Description > ------- > > Mainly needed for broker side to detect the different versions and to detect > if a SASL layer has been requested. > > > This addresses bug QPID-4368. > https://issues.apache.org/jira/browse/QPID-4368 > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h 1397295 > /trunk/qpid/cpp/src/qpid/framing/ProtocolInitiation.cpp 1397295 > /trunk/qpid/cpp/src/qpid/framing/ProtocolVersion.cpp 1397295 > > Diff: https://reviews.apache.org/r/7563/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
