----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8811/#review15078 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.h <https://reviews.apache.org/r/8811/#comment32656> I think the problem is that QMF still needs to publish deleted objects, regardless of clustering. The DeletedObject structure was added to make it easier to import/export deleted obj info specifically for clusters. In the past, we kept the original obj around (marked deleted) but that was difficult to export/import acrosss a cluster. So we added a "summary" object (DeletedObject) to represent deleted objects. The minimal cleanup would be to just remove the import/export functionality for deleted objects - probably not worth the effort to revert the whole DeletedObject stuff back to the pre-cluster method IMHO. - Kenneth Giusti On Jan. 3, 2013, 10:17 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8811/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 10:17 p.m.) > > > Review request for qpid and Kenneth Giusti. > > > Description > ------- > > Removing DeletedObject code from ManagementAgent as it is only required by > the defunct cluster code. > > Seeing tests fail: tests/BrokerMgmtAgent.cpp(258): error in "v1ObjPublish": > check isDeleted failed > > Is the existing change valid, and what needs to be done to pass the tests? > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1428634 > /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1428634 > /trunk/qpid/cpp/src/tests/BrokerMgmtAgent.cpp 1428634 > > Diff: https://reviews.apache.org/r/8811/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
