-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8862/
-----------------------------------------------------------

Review request for qpid, Gordon Sim and Ted Ross.


Description
-------

First off - this patch does _not_ fix the federation bugs involving headers 
exchanges.  So it's not a fix for qpid-3356.  But it does address one issue 
pointed out by Gordon in qpid-3356: the headers exchange did not correctly 
preserve the uniqueness of exchange+queue+key as a mgmt index to bindings.

This patch addresses that aspect of qpid-3356 by tracking the exchange's 
current bindings a bit better, and preventing the configuration of duplicate 
bindings regardless of the associated argument values.


This addresses bug qpid-3356.
    https://issues.apache.org/jira/browse/qpid-3356


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1428944 
  /trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1428944 
  /trunk/qpid/cpp/src/tests/ExchangeTest.cpp 1428944 
  /trunk/qpid/cpp/src/tests/federation.py 1428944 

Diff: https://reviews.apache.org/r/8862/diff/


Testing
-------

unit tests updated.


Thanks,

Kenneth Giusti

Reply via email to