[
https://issues.apache.org/jira/browse/QPID-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548456#comment-13548456
]
Pavel Moravec commented on QPID-3689:
-------------------------------------
When implementing this improvement, please make --tcp-nodelay option similar to
--auth (i.e. one can specify if the option is "on" or "off"). Current behavior
is quite misleading:
$ qpidd --trace --tcp-nodelay=no
2013-01-09 12:24:37 [System] debug Exception constructed: Error in command line
options: extra parameter in 'tcp-nodelay'
$ qpidd --trace --tcp-nodelay no
..
(tcp_nodelay is switched _ON_)
$ qpidd --trace --tcp-nodelay false
..
(tcp_nodelay is switched _ON_)
$ qpidd --trace --tcp-nodelay=false
2013-01-09 12:29:37 [System] debug Exception constructed: Error in command line
options: extra parameter in 'tcp-nodelay'
$ qpidd --trace
..
(tcp_nodelay is switched off)
Isn't it enough to apply this "patch" for this?
--- ./src/qpid/broker/Broker.cpp_orig 2013-01-09 12:31:22.599030546 +0100
+++ ./src/qpid/broker/Broker.cpp_new 2013-01-09 12:31:44.028904499 +0100
@@ -158,7 +158,7 @@ Broker::Options::Options(const std::stri
("auth", optValue(auth, "yes|no"), "Enable authentication, if disabled
all incoming connections will be trusted")
("realm", optValue(realm, "REALM"), "Use the given realm when
performing authentication")
("default-queue-limit", optValue(queueLimit, "BYTES"), "Default
maximum size for queues (in bytes)")
- ("tcp-nodelay", optValue(tcpNoDelay), "Set TCP_NODELAY on TCP
connections")
+ ("tcp-nodelay", optValue(tcpNoDelay, "yes|no"), "Set TCP_NODELAY on
TCP connections")
("require-encryption", optValue(requireEncrypted), "Only accept
connections that are encrypted")
("known-hosts-url", optValue(knownHosts, "URL or 'none'"), "URL to
send as 'known-hosts' to clients ('none' implies empty list)")
("sasl-config", optValue(saslConfigPath, "DIR"), "gets sasl config
info from nonstandard location")
> Enable TCP_NODELAY by default
> -----------------------------
>
> Key: QPID-3689
> URL: https://issues.apache.org/jira/browse/QPID-3689
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client
> Affects Versions: 0.15
> Reporter: Justin Ross
>
> As was done for the Java client at
> https://issues.apache.org/jira/browse/QPID-3610. This is widely held to be a
> better default because it improves performance in a broader set of cases than
> the converse.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
