----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8805/#review15765 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Jan. 28, 2013, 4:18 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8805/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 4:18 p.m.) > > > Review request for qpid, Ted Ross and Rafael Schloming. > > > Description > ------- > > This patch defines a more formal separation of the I/O processing done by the > SASL, SSL, and AMQP layers. This patch lays the groundwork for solving > PROTON-152. > > This patch introduces an object that represents an I/O processing layer: > pn_io_layer_t. This internal type is used as the 'base class' for the SASL, > SSL, and AMQP input/output processing logic. > > Layers are stored in the transport in an ordered list. The transport writes > input to and reads output from the lowest io layer (head of the list). Each > layer processes/transforms the I/O before optionally passing control to the > next layer. > > > This addresses bug proton-152. > https://issues.apache.org/jira/browse/proton-152 > > > Diffs > ----- > > /proton/trunk/proton-c/src/engine/engine-internal.h 1439349 > /proton/trunk/proton-c/src/engine/engine.c 1439349 > /proton/trunk/proton-c/src/sasl/sasl.c 1439349 > /proton/trunk/proton-c/src/ssl/openssl.c 1439349 > /proton/trunk/proton-c/src/ssl/ssl-internal.h 1439349 > > Diff: https://reviews.apache.org/r/8805/diff/ > > > Testing > ------- > > unit tests only. > > > Thanks, > > Kenneth Giusti > >
