----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9450/#review16647 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Feb. 15, 2013, 2:55 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9450/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2013, 2:55 p.m.) > > > Review request for qpid, Cliff Jansen and Rafael Schloming. > > > Description > ------- > > Proposed patch. It requires the work already done in PROTON-225, so this > patch must be layered on top of that. > > 1) messenger checks for buffered output bytes in transport > 2) removes the buffering done in the driver (no longer needed due to > PROTON-225) > 3) transport reports the number of bytes it has buffered (along with any > bytes buffered by the SASL and SSL layers). > > Cliff - I've synced the changes from the posix/driver.c file into > windows/driver.c. I haven't verified the windows/driver.c changes yet, but > will do so shortly. > > > This addresses bug proton-222. > https://issues.apache.org/jira/browse/proton-222 > > > Diffs > ----- > > /proton/branches/kgiusti-proton-225/proton-c/include/proton/engine.h > 1446334 > /proton/branches/kgiusti-proton-225/proton-c/src/engine/engine-internal.h > 1446334 > /proton/branches/kgiusti-proton-225/proton-c/src/engine/engine.c 1446334 > /proton/branches/kgiusti-proton-225/proton-c/src/messenger.c 1446334 > /proton/branches/kgiusti-proton-225/proton-c/src/posix/driver.c 1446334 > /proton/branches/kgiusti-proton-225/proton-c/src/ssl/openssl.c 1446334 > /proton/branches/kgiusti-proton-225/proton-c/src/windows/driver.c 1446334 > > Diff: https://reviews.apache.org/r/9450/diff/ > > > Testing > ------- > > Works against my reproducer. > > > Thanks, > > Kenneth Giusti > >
