----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/#review16693 -----------------------------------------------------------
For Visual Studio, the add_test will need to be changed slightly to expand to: python.exe "C:/proton/trunk/proton-c/env.py" "PYTHONPATH=C:/proton/trunk/tests/python;c:/proton/trunk/proton-c/bindings/python/Release;c:/proton/trunk/proton-c/bindings/python;c:/proton/trunk/proton-c" "python" "c:/proton/trunk/tests/python/proton-test" for the Release mode, and python.exe "C:/proton/trunk/proton-c/env.py" "PYTHONPATH=C:/proton/trunk/tests/python;c:/proton/trunk/proton-c/bindings/python/Debug;c:/proton/trunk/proton-c/bindings/python;c:/proton/trunk/proton-c" "python" "c:/proton/trunk/tests/python/proton-test" for Debug mode. I added two changes to get the test to work in Visual Studio. The first is just a note for python in Windows. I couldn't find the Python Debug library to download, so the pyconfig.h file in the python folder can be changed to set the pythonxx.lib for debug and release. e.g. # pragma comment(lib,"python27.lib") for both debug and release. Otherwise the project fails to build, since it can't find for the pythonxx_d.lib I looked at how Linux was working and noticed the test run was slightly different. It had the word PYTHON after the PYTHONPATH. Also the output from Visual Studio normally goes to the Release or Debug folder, so I added that in the PYTHONPATH. - Mary Hinton On Feb. 13, 2013, 7:41 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9433/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 7:41 p.m.) > > > Review request for qpid and Mary Hinton. > > > Description > ------- > > The smallest useful example I could devise to illustrate the possibilities. > > See https://issues.apache.org/jira/browse/PROTON-238 for more info > > > This addresses bug PROTON-238. > https://issues.apache.org/jira/browse/PROTON-238 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/qpid/proton/trunk/CMakeLists.txt 1445761 > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt > 1445761 > > Diff: https://reviews.apache.org/r/9433/diff/ > > > Testing > ------- > > linux only so far. Minimally the PYTHONPATH will require a ';' separator in > Windows. > > > Thanks, > > Cliff Jansen > >