-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/#review16790
-----------------------------------------------------------
These broker side changes look good, however, on trunk, qpid-config doesn't
seem to pass along the if_empty or if_unused flags.
Specifically, when I:
qpid-config --force del queue ken
I get this on the broker log:
2013-02-20 15:19:39 [Management] debug RECV MethodRequest (v2)
class=org.apache.qpid.broker:broker method=delete
replyTo=qmf.default.topic/direct.3dcd54bb-44d2-4e26-b031-0e1c75a0851d
objId=0-0-0--0(org.apache.qpid.broker:broker:amqp-broker) inArgs={name:ken,
type:queue}
2013-02-20 15:19:39 [Broker] debug Broker::delete(queue, ken,{})
That empty map in the last log message should include those two flags, but
they're not present.
Are changes needed in qpid-config to pass those flags to delete?
- Kenneth Giusti
On Feb. 20, 2013, 7:25 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9510/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 7:25 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Description
> -------
>
> Adds a check() method to the broker and passes it to queueDelete to inspect
> the if_unused and if_empty flags.
>
>
> This addresses bug QPID-4559.
> https://issues.apache.org/jira/browse/QPID-4559
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
>
> Diff: https://reviews.apache.org/r/9510/diff/
>
>
> Testing
> -------
>
> unit tests: created queue, added messages, deleted queue with and without
> flags and with and without messages and connections
>
>
> Thanks,
>
> Ernie Allen
>
>
