[
https://issues.apache.org/jira/browse/QPID-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589628#comment-13589628
]
Alex Rudyy commented on QPID-4609:
----------------------------------
Hi Jakub,
You are absolutely right. It is a bug. I committed a fix in revision
http://svn.apache.org/r1451243 . Thanks for pointing out the issue.
> Incorrect lock in the synchronize statement in
> org.apache.qpid.server.model.adapter.BrokerAdapter
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-4609
> URL: https://issues.apache.org/jira/browse/QPID-4609
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.21
> Reporter: JAkub Scholz
> Assignee: Alex Rudyy
> Priority: Minor
>
> The getTrustStores() and getKeyStores() methods of the BrokerAdapter class
> seem use both the _trustStores object as a lock for the sychronize statement:
> @Override
> public Collection<KeyStore> getKeyStores()
> {
> synchronized(_trustStores)
> {
> return Collections.unmodifiableCollection(_keyStores.values());
> }
> }
> @Override
> public Collection<TrustStore> getTrustStores()
> {
> synchronized(_trustStores)
> {
> return Collections.unmodifiableCollection(_trustStores.values());
> }
> }
> Is that a bug? I would assume that the getKeyStores method should use the
> _keyStores object instead of _trustStores.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
