Chuck Rolke created QPID-4618:
---------------------------------

             Summary: C++ Broker ACL test suite too fragile detecting errors
                 Key: QPID-4618
                 URL: https://issues.apache.org/jira/browse/QPID-4618
             Project: Qpid
          Issue Type: Test
          Components: C++ Broker
    Affects Versions: 0.20
            Reporter: Chuck Rolke


Writing tests for the python ACL test suite is difficult. Recent experience 
with QPID-4604 demonstrated this again recently.

The basic problem with ACL tests is that some test actions are supposed to fail 
but the reason for the failure is not easily known. For instance, if a user has 
a configured queue limit and he tries to create too many queues then: 
* The request will be denied by the ACL limit code. This is what your are 
testing and is the expected result.
* Or the request may be denied because a queue of the same name already exists. 
* Or it may be denied because the user has too many connections to the broker 
and the connection was denied.
* Or an operation failed and the broker closed the session that was executing 
the test. Python then fails because the session object is dead not because the 
operation that the session was executing failed.

It is possible to write a series of tests with proper actual/expected result 
paths and all the tests will pass. However, an exported trace log file shows 
that the test code never executed the tests to completion.

The Acl test suite needs some attention to aid future maintainers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to