----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11378/#review21155 -----------------------------------------------------------
Ship it! /trunk/qpid/cpp/src/qpid/broker/MessageInterceptor.h <https://reviews.apache.org/r/11378/#comment43927> I have a slight preference for 'publish()' rather than 'push()', i.e. modify a message before it is published (made available to subscribers). In the future there then may be another method in the interface named 'record()', for modifying a message before it is written to disk. - Gordon Sim On May 29, 2013, 2:36 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11378/ > ----------------------------------------------------------- > > (Updated May 29, 2013, 2:36 p.m.) > > > Review request for qpid, Gordon Sim and Kenneth Giusti. > > > Description > ------- > > QPID-4886: Pass non-const reference to Message in QueueObserver functions. > > Based on discussion on https://reviews.apache.org/r/11378/ we will not modify > QueueObserver to allow message modification as it violates the existing > semantics. Instead this patch introduces a new class MessageInterceptor for > that > purpose. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/MessageInterceptor.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/broker/Queue.h 1487501 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1487501 > > Diff: https://reviews.apache.org/r/11378/diff/ > > > Testing > ------- > > make test > > > Thanks, > > Alan Conway > >
