> On July 4, 2013, 2:43 p.m., Alan Conway wrote: > > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp, line 848 > > <https://reviews.apache.org/r/12249/diff/1/?file=317952#file317952line848> > > > > Lock order, this is called with messageLock held. Need a note somewhere > > to explicitly state the lock order rules for Queue.
I removed the ownership lock entirely, as it was only used for the owner field and even there not consistently. Now just uses the same lock as the other users fields. > On July 4, 2013, 2:43 p.m., Alan Conway wrote: > > /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp, line 267 > > <https://reviews.apache.org/r/12249/diff/1/?file=317960#file317960line267> > > > > I don't understand the usePrimary/trackPrimary code. I don't see how it > > relates to HA primary status. > > Gordon Sim wrote: > It has nothing to do with HA. I'll come up with a different name. It > indicates whether the link that caused it to be created is still using it. Changed avoid this confusion and hopefully signal purpose more clearly. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/#review22765 ----------------------------------------------------------- On July 3, 2013, 3:22 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12249/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 3:22 p.m.) > > > Review request for qpid, Alan Conway and Kenneth Giusti. > > > Bugs: QPID-4976 > https://issues.apache.org/jira/browse/QPID-4976 > > > Repository: qpid > > > Description > ------- > > This adds the ability to have queue autodeleted when no longer used, when > empty or when both no longer used and empty as specified in the standard > lifetime policies for AMQP 1.0. The ability to only delete if unused and > empty is useful for 0-10 also so I've allowed these to be set there as well. > > The basic change is to have an optional policy specified that dictates what > autodelete means. The default is to autodelete when not used. A queue is in > use if it is being consumed or browsed, or if in 0-10 it has been declared as > an exclusive queue and the declaring session is still active. Additionally > over 1.0 the queue is in use if there is any sender attached to it. > Autodeletion is now triggered automatically by the queue when some other > operation moves it to a state eligible for deletion. To avoid this on a > backup in ha, the queue replicator flags the replica as in use. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/amqp/descriptors.h 1497827 > /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/Lvq.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/Queue.h 1497827 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1497827 > /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.h 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.h 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1497827 > /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1497827 > /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1497827 > /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1497827 > /trunk/qpid/cpp/src/qpid/messaging/amqp/AddressHelper.cpp 1497827 > /trunk/qpid/cpp/src/tests/QueueTest.cpp 1497827 > > Diff: https://reviews.apache.org/r/12249/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
