> On Aug. 16, 2013, 6:13 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp, line 447 > > <https://reviews.apache.org/r/13619/diff/1/?file=342087#file342087line447> > > > > Do you need both set and notifyRequired? It looks like set is only > > non-empty if notifyRequired (but I may have missed a case). > > Gordon Sim wrote: > There is no way to test the set however. Now an alternative fix would of > course be to add such a method and use that. This approach seemed reasonable > to me.
It occurs to me that I may have misunderstood your point. Are you saying that the conditional notify() is not needed, since it is a no-op if the set is not populated? That would in fact be the case and would make the change simpler. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13619/#review25238 ----------------------------------------------------------- On Aug. 16, 2013, 5:09 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13619/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 5:09 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-5078 > https://issues.apache.org/jira/browse/QPID-5078 > > > Repository: qpid > > > Description > ------- > > This change ensures that if a consumer with a filter/selector skips over a > message, then other listeners or consumers will still get notified of the > availability of that skipped message. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1514329 > > Diff: https://reviews.apache.org/r/13619/diff/ > > > Testing > ------- > > make test passes > > > Thanks, > > Gordon Sim > >
