[
https://issues.apache.org/jira/browse/QPID-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796976#comment-13796976
]
Robbie Gemmell commented on QPID-5242:
--------------------------------------
I know the patch isn't finished, but...I dont think the below lines are the
problem, they should probably stay the way they are. The fix is likely to be in
the queue creation path of the REST layer.
{noformat}
---
a/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/QueueAdapter.java
+++
b/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/QueueAdapter.java
@@ -387,12 +387,12 @@ final class QueueAdapter extends AbstractAdapter
implements Queue, AMQQueue.Subs
}
else if(MESSAGE_GROUP_KEY.equals(name))
{
- return _queue.getAttribute(MESSAGE_GROUP_KEY);
+ return
_queue.getAttribute(QueueArgumentsConverter.QPID_GROUP_HEADER_KEY);
}
else if(MESSAGE_GROUP_SHARED_GROUPS.equals(name))
{
//We only return the boolean value if message groups are actually
in use
- return getAttribute(MESSAGE_GROUP_KEY) == null ? null :
_queue.getAttribute(MESSAGE_GROUP_SHARED_GROUPS);
+ return getAttribute(MESSAGE_GROUP_KEY) == null ? null :
_queue.getAttribute(QueueArgumentsConverter.QPID_SHARED_MSG_GROUP);
}
else if(LVQ_KEY.equals(name))
{
{noformat}
The general changes that have occurred in the past which caused the problem
were around making more of the broker core use the 'new model attributes',
rather than its historic use of the 'old on-the-wire arguments', but those
changes overlooked the fact that the REST layer for queue creation explicitly
converts the incoming attribute names passed to it back to the old names,
meaning the above attribute lookups fail in some cases (I imagine they do work
in others).
> [Java Broker] The queue adapter does not return correct values for attributes
> "messageGroupKey" and "messageGroupSharedGroups"
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-5242
> URL: https://issues.apache.org/jira/browse/QPID-5242
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.25
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 0.25
>
> Attachments:
> 0001-QPID-5242-Fix-queue-adapter-to-return-correct-values.patch
>
>
> The queue adapter does not return nulls for attributes "messageGroupKey" and
> "messageGroupSharedGroups" regardless whether they are set or not
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
