----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15322/#review28563 -----------------------------------------------------------
Ship it! This is an improvement. The only change you should make is to replace "address" with "container" (like it was before). Calling the container name an address overloads the term too much. Please raise a Jira against Qpid (component Qpid Dispatch) and attach the patch. - Ted Ross On Nov. 8, 2013, 6:28 p.m., Ernie Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15322/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 6:28 p.m.) > > > Review request for qpid and Ted Ross. > > > Repository: qpid > > > Description > ------- > > Respond to a management request to display the list of connections for a > dispatch router. > The router responds with the following info for each connection: > container - the name of the router handling the request > state - the state of the connection (Connecting, Opening, Operational, > Failed, User) > host - the host of the connection's container > port - the post of the connection's container > sasl - the sasl mechanism list of the connection's container > role - the role of the connection's container > > tools/src/py/qdstat was updated to honor the -c command line switch. > ./qdstat -c -b localhost:20001 > container state host port sasl role > =========================================================== > QDR.A Operational 0.0.0.0 20002 ANONYMOUS inter-router > QDR.A Operational 0.0.0.0 20003 ANONYMOUS inter-router > QDR.A Operational 0.0.0.0 20004 ANONYMOUS inter-router > > > Diffs > ----- > > /dispatch/trunk/src/server.c 1538673 > /dispatch/trunk/src/server_private.h 1538673 > /dispatch/trunk/tools/src/py/qdstat 1538673 > > Diff: https://reviews.apache.org/r/15322/diff/ > > > Testing > ------- > > Start a network of routers > Display connections using qdstat -c for each router > Verify connections match config file entries for each router > Kill a router in the network > Verify connections to the killed router are no longer listed > Restart the killed router > Verify connections to the restarted router are displayed > > > Thanks, > > Ernie Allen > >
