-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15747/
-----------------------------------------------------------

(Updated Nov. 21, 2013, 1:19 p.m.)


Review request for qpid, Andrew Stitcher and Ted Ross.


Bugs: qpid-5369
    https://issues.apache.org/jira/browse/qpid-5369


Repository: qpid


Description (updated)
-------

Causes the compiler to issue deprecation warnings when the C++ Agent or Console 
API classes are used by applications.  Works for GNU C and Microsoft Visual C++ 
only.

Update: I'd like this change considered for 0.26 release, so please indicate 
whether you approve this change on the jira 
https://issues.apache.org/jira/browse/qpid-5369 so I can ping Justin for 
approval.

thanks


Diffs
-----

  /trunk/qpid/cpp/bindings/qmf2/examples/cpp/CMakeLists.txt 1543123 
  /trunk/qpid/cpp/bindings/qmf2/python/CMakeLists.txt 1543123 
  /trunk/qpid/cpp/bindings/qmf2/ruby/CMakeLists.txt 1543123 
  /trunk/qpid/cpp/include/qmf/Agent.h 1543123 
  /trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123 
  /trunk/qpid/cpp/include/qmf/AgentSession.h 1543123 
  /trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123 
  /trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123 
  /trunk/qpid/cpp/include/qmf/Data.h 1543123 
  /trunk/qpid/cpp/include/qmf/DataAddr.h 1543123 
  /trunk/qpid/cpp/include/qmf/ImportExport.h 1543123 
  /trunk/qpid/cpp/include/qmf/Query.h 1543123 
  /trunk/qpid/cpp/include/qmf/Schema.h 1543123 
  /trunk/qpid/cpp/include/qmf/SchemaId.h 1543123 
  /trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123 
  /trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123 
  /trunk/qpid/cpp/include/qmf/Subscription.h 1543123 
  /trunk/qpid/cpp/include/qmf/exceptions.h 1543123 
  /trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123 

Diff: https://reviews.apache.org/r/15747/diff/


Testing
-------

Removed the warning suppression flags and built the Agent and Console examples 
on linux and windows - validated that the proper deprecation warnings were 
issued.


Thanks,

Kenneth Giusti

Reply via email to