> On Jan. 3, 2014, 12:22 a.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/tests/ha_tests.py, line 237 > > <https://reviews.apache.org/r/16577/diff/1/?file=413695#file413695line237> > > > > This doesn't appear to be an HA test why is it in these tests?
Agreed, should be in the qpid/python tests somewhere. I'll look for an appropriate place. > On Jan. 3, 2014, 12:22 a.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/tests/ha_tests.py, line 243 > > <https://reviews.apache.org/r/16577/diff/1/?file=413695#file413695line243> > > > > I don't see anywhere that you send SIGCONT to the broker to get it to > > carry on - how do subsequent tests work? The brokertest framework automatically tears down processes (including brokers) started by each test, each test starts new brokers as needed. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16577/#review31093 ----------------------------------------------------------- On Jan. 2, 2014, 10:15 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16577/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 10:15 p.m.) > > > Review request for qpid, Gordon Sim and Rafael Schloming. > > > Bugs: qpid-5428 > https://issues.apache.org/jira/browse/qpid-5428 > > > Repository: qpid > > > Description > ------- > > QPID-5428: Heartbeats not in use when attempting to connect with python > client. > > The heartbeat setting was ignored when opening a connection, so opening a > connection could hang indefinitely unless a timeout was set. > > The fix is to set the timeout to 2x heartbeat if a heartbeat interval is set. > > > Diffs > ----- > > /trunk/qpid/cpp/src/tests/ha_tests.py 1554805 > /trunk/qpid/python/qpid/messaging/endpoints.py 1554805 > > Diff: https://reviews.apache.org/r/16577/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
