----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17418/#review32877 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Jan. 27, 2014, 8:32 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17418/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 8:32 p.m.) > > > Review request for qpid, Chug Rolke and Rafael Schloming. > > > Bugs: PROTON-488 > https://issues.apache.org/jira/browse/PROTON-488 > > > Repository: qpid > > > Description > ------- > > See the parent Jira comment description of the bug with the first patch. > > This patch achieves the same thing but by forcing all 'z' encodings to be > passed as a single pn_bytes_t struct and "retrieved" as a single pn_bytes_t > struct via va_arg(). > > The other patch is a single line but this one is fairly isolated too. I > slightly prefer this one because a pn_bytes_t struct is used going the other > way (in pn_data_vscan, but by a pointer to the struct on the stack). I don't > see a performance difference either way. We just have to stick to one > paradigm everywhere in the code, either "struct in and out", or "separate > size_t and char* in and out". > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c > 1561193 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.c > 1561193 > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c > 1561193 > > Diff: https://reviews.apache.org/r/17418/diff/ > > > Testing > ------- > > 64 bit, windows and linux > > > Thanks, > > Cliff Jansen > >
