[
https://issues.apache.org/jira/browse/QPID-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941750#comment-13941750
]
Alex Rudyy commented on QPID-5048:
----------------------------------
Andrew,
I looked through today's patch. Here are my comments:
1) The java code does not conform Qpid code style
2) I am not sure about location of the qpid-enforcer-plugin-rules plugin. IMHO,
it needs to go into a separate project. Maybe, maven/plugins in the qpid svn
repo
3) I cannot see any maven code using implemented custom rule. Also, the custom
rule is implemented to always use the first file in the list of files as a
reference file. Is it intentional?
4) Do we really need a window command line?
{noformat}
<profile.broker.command>${qpid.home}${file.separator}bin${file.separator}qpid-server
-sp @STORE_PATH -st @STORE_TYPE -l @LOG_CONFIG_FILE</profile.broker.command>
<profile.broker.command.windows>${qpid.home}${file.separator}bin${file.separator}qpid-server.bat
-sp @STORE_PATH -st @STORE_TYPE -l
@LOG_CONFIG_FILE</profile.broker.command.windows>
{noformat}
I believe that Windows automatically adds extension ".bat" to the batch file.
It is unclear for me why the windows command line is needed.
> [Java] Implement a Maven 3 build system
> ----------------------------------------
>
> Key: QPID-5048
> URL: https://issues.apache.org/jira/browse/QPID-5048
> Project: Qpid
> Issue Type: Task
> Components: Build Tools
> Reporter: Rob Godfrey
> Assignee: Robbie Gemmell
> Attachments:
> 0001-QPID-5048-Maven-POM-refactoring-names-descriptions-d.patch,
> 0001-QPID-5048-Maven-enahancements-to-remove-child-versio.patch,
> 0001-QPID-5048-Maven-enahancements-to-restructure-POM-hie.patch,
> 0001-QPID-5048-Moved-slf4j-deps-to-test-utils-to-workarou.patch,
> 0001-QPID-5048-changes-get-perf-tests-running-again.patch,
> 0001-QPID-5048-dby-profiles-bdb-test-deps-and-config-for-.patch,
> 0001-QPID-5048-split-out-systests-from-perftests-and-add-.patch,
> 0001-QPID-5048-surefire-site-coverage-and-jxr-config.patch,
> 0002-QPID-5048-Logging-dependency-and-configuration-tidy-.patch,
> 0003-QPID-5048-logging-and-build-output-cleanup.patch,
> QPID-5048-maven-qpid-parent-changes.diff
>
>
> Implement a Maven build system which generates the same artefacts as the
> current ant based build.
> See: https://cwiki.apache.org/confluence/display/qpid/Java+Build+System
> TO DO
> - Fix what the systests/perftests do to copy the test-profiles dir to the
> necessary location.
> - Test deploying the modules to a local Nexus instance (by overriding the
> repo properties locally).
> - Ensure we dont deploy modules we aren't already doing so, it will make
> changing them later less of a pain for everyone.
> - Align the XML in the pom files consistently, fix whitepsace errors.
> - improve the performance hit from using the license plugin
> - check that perf-tests actually needs the unpacked broker for running non
> spawn profiles and remove if not
> - remove the child module version to let them inherit from java parent
> - check the bcel bundle dependancy exclusions are still required
> === Once the Ant build is removed ===
> - Move all the resources to be in the /src/foo/resources folders.
> - Make qpidversion.properties in common be a filtered resource instead of
> generated.
> - Get rid of the antrun-plugin execution in common, directly invoke the
> required java elements.
> - Do the above in the generate-sources-common profile instead of current
> default config.
> - Get rid of the antrun-plugin execution in broker-core, directly invoke the
> required java elements.
> - Fix the tests not to be dependant on the working dir being the java dir.
> - Fix the tests not to be dependant on the test config/output dirs being
> children of qpid.home.
> - Remove the QBTC output file mechanics, rely on Surefire to do it?
> - JUnit test profiles instead of Exludes files?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
