----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20049/#review39799 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On April 8, 2014, 4:16 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20049/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 4:16 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Bugs: PROTON-557 > https://issues.apache.org/jira/browse/PROTON-557 > > > Repository: qpid > > > Description > ------- > > Modifies the Event API to provide more granularity for endpoint state > changes. Includes both remote and local state changes as separate event > types. Also introduces event categories, should we want to provide > additional event generators (eg, messenger, store) and event filtering. > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1583716 > /proton/trunk/proton-c/include/proton/event.h 1583716 > /proton/trunk/proton-c/src/engine/engine.c 1583716 > /proton/trunk/proton-c/src/engine/event.c 1583716 > /proton/trunk/proton-c/src/messenger/messenger.c 1583716 > /proton/trunk/proton-c/src/transport/transport.c 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ConnectionImpl.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EndpointImpl.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/LinkImpl.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/SenderImpl.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/SessionImpl.java > 1583716 > > /proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java > 1583716 > /proton/trunk/proton-j/src/main/resources/cengine.py 1583716 > /proton/trunk/tests/python/proton_tests/engine.py 1583716 > > Diff: https://reviews.apache.org/r/20049/diff/ > > > Testing > ------- > > Updated unit tests to check for new event types. > > > Thanks, > > Kenneth Giusti > >
