----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20854/ -----------------------------------------------------------
Review request for qpid. Repository: qpid Description ------- This patch modifies the proton factories to conform to the following pattern. Any given interface 'package.Interface' has a static inner class Factory that can be used to construct the interface as follows: package.Interface iface = package.Interface.Factory.create(...); Previously every interface had a corresponding factory interface called InterfaceFactory and it had an implementation called InterfaceFactoryImpl. The old construction sequence would look something like this: package.InterfaceFactory interfaceFactory = package.impl.InterfaceFactoryImpl(); // in some cases this would be package.impl.subpackage.InterfaceFactoryImpl() package.Interface iface = interfaceFactory.create(...); // in some cases this would be createInterface(...); Diffs ----- proton/trunk/contrib/proton-hawtdispatch/src/main/java/org/apache/qpid/proton/hawtdispatch/api/AmqpSession.java 1591010 proton/trunk/contrib/proton-hawtdispatch/src/main/java/org/apache/qpid/proton/hawtdispatch/api/MessageDelivery.java 1591010 proton/trunk/contrib/proton-hawtdispatch/src/main/java/org/apache/qpid/proton/hawtdispatch/impl/AmqpTransport.java 1591010 proton/trunk/contrib/proton-hawtdispatch/src/test/java/org/apache/qpid/proton/hawtdispatch/test/MessengerServer.java 1591010 proton/trunk/contrib/proton-jms/src/main/java/org/apache/qpid/proton/jms/AMQPNativeOutboundTransformer.java 1591010 proton/trunk/contrib/proton-jms/src/main/java/org/apache/qpid/proton/jms/EncodedMessage.java 1591010 proton/trunk/contrib/proton-jms/src/main/java/org/apache/qpid/proton/jms/JMSMappingOutboundTransformer.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/Proton.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/ProtonFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/ProtonFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/ProtonFactoryLoader.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/codec/Codec.java PRE-CREATION proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/codec/Data.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/codec/DataFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/codec/impl/DataFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/Driver.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/DriverFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/impl/ConnectorImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/impl/DriverFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/impl/DriverImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Collector.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Connection.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Engine.java PRE-CREATION proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/EngineFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/SslDomain.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/SslPeerDetails.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/Transport.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EngineFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslDomainImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslPeerDetailsImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/message/Message.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/message/MessageFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/message/impl/MessageFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/Messenger.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/MessengerFactory.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerFactoryImpl.java 1591010 proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/ProtonFactoryLoaderTest.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/factoryloadertesting/DummyProtonCFactory.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/factoryloadertesting/DummyProtonFactory.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/factoryloadertesting/DummyProtonJFactory.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/systemtests/ProtonEngineExampleTest.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/systemtests/ProtonFactoryTest.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/systemtests/SimpleTest.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/systemtests/engine/ConnectionTest.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/systemtests/engine/ProtonFactoryTestFixture.java 1591010 proton/trunk/proton-j/src/test/java/org/apache/qpid/proton/systemtests/engine/TransportTest.java 1591010 proton/trunk/tests/java/org/apache/qpid/proton/InteropTest.java 1591010 Diff: https://reviews.apache.org/r/20854/diff/ Testing ------- All tests pass. Thanks, Rafael Schloming
