I'm getting up to speed with the router code, I had a couple of questions: alloc.c: Do we have performance data that shows this is better than malloc? Modern malloc() has optimizations for per-thread, small-object etc. etc. In my experience it's very hard to beat. The problem with custom alloc is: - it's more code to maintain, it's hard to get right. - it makes tools like valgrind much less useful.
qd_buffer_set_size/qd_buffer is not thread safe. We don't seem to use set_size, we should get rid of it if we don't need it or make it threads safe if we do. router_semantics_for_addr: linear search for address. This is not on the critical path for messages but it is on the path for subscriptions and we've seen situations in the past where creating subscriptions can be critical too. Thanks, and apologies if I've missed anything obvious. Cheers, Alan. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
