[
https://issues.apache.org/jira/browse/QPID-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015336#comment-14015336
]
Keith Wall edited comment on QPID-5781 at 6/2/14 12:22 PM:
-----------------------------------------------------------
Changes look reasonable to me. I do note the possibility of a AIOOBException
at line 67 if #close() races with a close connection over the wire. This
problem is not new, but with the new work to control the state of the virtual
host, this problem may be more likely to manifest in non-shutdown situations.
A separate Jira will be raised (QPID-5796)
was (Author: k-wall):
Changes look reasonable to me. I do note the possibility of a AIOOBException
at line 67 if #close() races with a close connection over the wire. This
problem is not new, but with the new work to control the state of the virtual
host, this problem may be more likely to manifest in non-shutdown situations.
A separate Jira will be raised.
> [Java broker] exceptions while closing entries in the ConnectionRegistry can
> prevent clean shutdown
> ---------------------------------------------------------------------------------------------------
>
> Key: QPID-5781
> URL: https://issues.apache.org/jira/browse/QPID-5781
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.20, 0.22, 0.24, 0.26, 0.28
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.29
>
>
> When the ConnectionRegistry is closed during broker shutdown, it attempts to
> close connections within a try-catch block and logs the exception. It is
> likely any such exception would mean the connection wont close and properly
> deregister, in which case the registry close process could sit looping
> retrying it.
> If an exception is thrown while closing a connection in the registry, it
> should be removed immediately to ensure the process cant infinite loop.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
