----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22273/#review45520 -----------------------------------------------------------
Ship it! +1 to andrew's comment - Rafael Schloming On June 11, 2014, 2:20 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22273/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 2:20 p.m.) > > > Review request for qpid, Andrew Stitcher and Rafael Schloming. > > > Bugs: PROTON-595 > https://issues.apache.org/jira/browse/PROTON-595 > > > Repository: qpid > > > Description > ------- > > Popen(file.py, ...) needs to run with shell=True on windows. On Linux the > tests hang when shell=True. This patch compromises by turning on the shell > arg when running on windows. > > Change the arg list to run Popen(python, file.py, ...) touches wider ranges > of source code with some risk and with no obvious benefit. > > > Diffs > ----- > > proton/trunk/tests/python/proton_tests/common.py 1601492 > > Diff: https://reviews.apache.org/r/22273/diff/ > > > Testing > ------- > > Passes tests on linux and windows. > > > Thanks, > > Chug Rolke > >
