----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22930/#review46527 -----------------------------------------------------------
Ship it! /trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp <https://reviews.apache.org/r/22930/#comment81971> Minor nitpick: extra space here. - Gordon Sim On June 24, 2014, 2:23 p.m., Ernie Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22930/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 2:23 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Repository: qpid > > > Description > ------- > > The duration calculation in sys/posix/AsyncIO.cpp readable() was happening > before the readCallback() call. This was allowing the loop to execute for > more than the allowable time (as set by threadMaxIoTimeNs). > > This patch just changes where the duration is calculated in readable() and > writeable(). > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp 1605080 > > Diff: https://reviews.apache.org/r/22930/diff/ > > > Testing > ------- > > Ran reproducer for https://bugzilla.redhat.com/show_bug.cgi?id=977869. The > connection delay dropped by 19%. > > > Thanks, > > Ernie Allen > >
