----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46903 -----------------------------------------------------------
Ship it! Ship It! - Darryl Pierce On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23130/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 5:06 p.m.) > > > Review request for qpid and Darryl Pierce. > > > Bugs: PROTON-620 > https://issues.apache.org/jira/browse/PROTON-620 > > > Repository: qpid > > > Description > ------- > > see PROTON-620 for rationale. > > Note that this also has a bug fix which stops python crashing when trying to > typemap non strings to pn_uuid_t > > > Diffs > ----- > > proton/trunk/proton-c/bindings/python/cproton.i 1606140 > proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 > proton/trunk/proton-c/include/proton/cproton.i 1606140 > > Diff: https://reviews.apache.org/r/23130/diff/ > > > Testing > ------- > > ctest succeeds for all languages that have tests. > > > Thanks, > > Andrew Stitcher > >