----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/#review46912 -----------------------------------------------------------
Actually it turns out when applying this patch that there is an issue. With the patch applied qpid-stat -u seems not to function. Also session listing e.g. through qpid-tool, now have the name duplicated as both short and long name are indexed. When these are the same this has no value and merely reduces readability. (Btw the diff to the management spec is to a file that no longer exists on trunk, it moved to cpp/src/qpid/broker/management-spec.xml. However I fixed that and found the issue above.) - Gordon Sim On June 25, 2014, 7:18 p.m., Ernie Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22975/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 7:18 p.m.) > > > Review request for qpid, Alan Conway and Gordon Sim. > > > Repository: qpid > > > Description > ------- > > AMQP 0-10 allows session names to be up to 2^16 bytes long; the QMF > management schema for the broker however defines the name of a session object > as being up to 2^8 bytes long. If a session is created with a name greater > than 256 bytes, the broker cannot send out management objects for it i.e. > periodic processing fails. > > This patch adds a new field in the management schema that handles the full > length name. The existing name field is truncated if needed. > Some of the management tools could be updated to use the new field. qpid-tool > works without modifications. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1605518 > /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1605518 > /trunk/qpid/cpp/src/qpid/broker/management-schema.xml 1605518 > > Diff: https://reviews.apache.org/r/22975/diff/ > > > Testing > ------- > > - Added session name that was 1024 characters long. > - Checked the message log to verify the absence of the following exception > [System] error Exception thrown by timer task > ManagementAgent::periodicProcessing: Could not encode string of 1061 bytes as > uint8_t string. > (/home/eallen/current/qpid/cpp/src/qpid/framing/Buffer.cpp:246) > - Ran qpid-tool and saw the presence of the truncated session name in the > existing field, and the full name in the new field. > > The new field is named "fullName". > > > Thanks, > > Ernie Allen > >
