----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24307/#review49598 -----------------------------------------------------------
Ship it! I think this is along the right lines. - Andrew Stitcher On Aug. 5, 2014, 11:08 a.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24307/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 11:08 a.m.) > > > Review request for qpid, Andrew Stitcher and Kim van der Riet. > > > Bugs: QPID-5948 > https://issues.apache.org/jira/browse/QPID-5948 > > > Repository: qpid > > > Description > ------- > > Suggested expansion of fix in https://reviews.apache.org/r/24251 to: (a) > handle more general exceptions and (b) to prevent the condition in the first > place by requiring that the exchange backing a durable topic is also durable. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/ObjectFactory.cpp 1615699 > /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp 1615699 > > Diff: https://reviews.apache.org/r/24307/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
