----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24381/#review49736 -----------------------------------------------------------
Ship it! Looks good module the parameter comment. proton/trunk/proton-c/include/proton/sasl.h <https://reviews.apache.org/r/24381/#comment87045> I'd suggest adding a true/false parameter here. I think we do (or probably should do that) for most other boolean options. - Rafael Schloming On Aug. 6, 2014, 1:27 p.m., Ted Ross wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24381/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 1:27 p.m.) > > > Review request for qpid, Andrew Stitcher and Rafael Schloming. > > > Bugs: PROTON-485 > https://issues.apache.org/jira/browse/PROTON-485 > > > Repository: qpid > > > Description > ------- > > This patch changes the Proton SASL transport-layer to make it tolerant of > peers that may or may not skip the SASL exchange. Some highlights: > > - Introduces a new sasl-outcome, PN_SASL_SKIPPED, to indicate that the > peer/client skipped the exchange. > - Introduces a new method, pn_sasl_allow_skip, for a server to use to allow > the client to skip sasl. > > Existing code that uses the SASL transport layer will continue to function > the same, except that there will be a better error message in the case of > skipped SASL. > > > Diffs > ----- > > proton/trunk/proton-c/bindings/python/proton.py 1616212 > proton/trunk/proton-c/include/proton/cproton.i 1616212 > proton/trunk/proton-c/include/proton/sasl.h 1616212 > proton/trunk/proton-c/src/sasl/sasl.c 1616212 > proton/trunk/tests/python/proton_tests/sasl.py 1616212 > > Diff: https://reviews.apache.org/r/24381/diff/ > > > Testing > ------- > > Unit test added > > > Thanks, > > Ted Ross > >
