[ 
https://issues.apache.org/jira/browse/QPID-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126764#comment-14126764
 ] 

Alex Rudyy commented on QPID-6074:
----------------------------------

Keith,

I would like to clarify why BDB HA VHN context variables ( 
"qpid.bdb.ha.master_transfer_interval",  "qpid.bdb.ha.db_ping_socket_timeout", 
"qpid.bdb.ha.remote_node_monitor_interval", 
"qpid.bdb.ha.environment_restart_retry_limit", 
"qpid.bdb.ha.executor_shutdown_timeout") have not been declared on BDB HA VHN?

I would expect them do be defined on BDB HA VHN interface using annotations 
similar to other context variables, for example
{code}
    String MASTER_TRANSFER_INTERVAL = ""qpid.bdb.ha.master_transfer_interval";
    @ManagedContextDefault(name =MASTER_TRANSFER_INTERVAL)
    int DEFAULT_MASTER_TRANSFER_TIMEOUT = 1000 * 60;
{code}

The way you implemented context variable defaults seem inconsistent with other 
code

> BDB HA VHN to use context variables rather than system property to control 
> timeouts etc
> ---------------------------------------------------------------------------------------
>
>                 Key: QPID-6074
>                 URL: https://issues.apache.org/jira/browse/QPID-6074
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>             Fix For: 0.31
>
>
> The BDB HA VHN implementation currently uses system properties for a number 
> of timeout values, polling frequencies and retry intervals.  These should be 
> converted to context variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to