----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29096/#review65200 -----------------------------------------------------------
Ship it! Ship It! - Rob Godfrey On Dec. 16, 2014, 1:24 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29096/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 1:24 p.m.) > > > Review request for qpid and Rob Godfrey. > > > Repository: qpid > > > Description > ------- > > Session holds a llist of all created receivers. This change ensures that once > closed they are removed from the list. Otherwise, with e.g. a jms > QueueBrowser, you can ened up creating (and closing) lots of receivers, and > the list just keeps growing. > > > Diffs > ----- > > > trunk/qpid/java/amqp-1-0-client/src/main/java/org/apache/qpid/amqp_1_0/client/Receiver.java > 1645937 > > Diff: https://reviews.apache.org/r/29096/diff/ > > > Testing > ------- > > All the test from mvn ran ok. > > My original QueueBrowser test is still showing some memory growth problems > even with this applied however, but as it seems like a simple and (to me) > logical fix, posting it for further comment. > > > Thanks, > > Gordon Sim > >
