----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31112/#review72726 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Feb. 17, 2015, 2:26 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31112/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 2:26 p.m.) > > > Review request for qpid and Darryl Pierce. > > > Bugs: PROTON-820 > https://issues.apache.org/jira/browse/PROTON-820 > > > Repository: qpid-proton-git > > > Description > ------- > > * On Windows the perl wrapper cmake runs with BUILD_WITH_CXX ON but is > compiled as C and fails. > * On Linux the perl wrapper runs with BUILD_WITH_CXX OFF and is compiled as C > successfully. > > This patch detects BUILD_WITH_CXX and if on then coaxes the build system to > use CXX for the perl wrapper C code. > Windows also requires a char* cast on a return from malloc. > > > Diffs > ----- > > proton-c/bindings/perl/CMakeLists.txt 2a25327 > proton-c/bindings/perl/perl.i cb44188 > > Diff: https://reviews.apache.org/r/31112/diff/ > > > Testing > ------- > > Passes self tests on Fedora 19 > > > Thanks, > > Chug Rolke > >
