> On March 3, 2015, 11:01 p.m., Alan Conway wrote: > > I agree with the name change but please don't break dispatch at this late > > date. Please add a utils.py with `from sync import *` for backwards > > compatibility, put a comment in there to say don't use it, deprecated, > > internal use only, beware of dragons etc. Maybe build dispatch against it > > just to be sure ;)
Good point/reminder re Dispatch. However *if* we went ahead with this change before 0.9, I would want to change Dispatch at the same time. AT that point the utils module would never have been released so introducing a legacy version just for the one internal use would be a bad choice. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31681/#review75072 ----------------------------------------------------------- On March 3, 2015, 2:39 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31681/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 2:39 p.m.) > > > Review request for qpid, Alan Conway, Justin Ross, and Rafael Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > In order to convey a little bit more about what the contents do. Just a > suggestion. > > > Diffs > ----- > > examples/python/helloworld_blocking.py d9a24a9 > examples/python/sync_client.py 82cd85f > proton-c/bindings/python/CMakeLists.txt 7f54033 > proton-c/bindings/python/proton/sync.py PRE-CREATION > proton-c/bindings/python/proton/utils.py d5e2e0a > tests/python/proton_tests/sync.py PRE-CREATION > tests/python/proton_tests/utils.py 727b586 > > Diff: https://reviews.apache.org/r/31681/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
