[ 
https://issues.apache.org/jira/browse/QPID-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388746#comment-14388746
 ] 

ASF GitHub Bot commented on QPID-6470:
--------------------------------------

GitHub user pavelpokutnev opened a pull request:

    https://github.com/apache/qpid/pull/6

    QPID-6470: FieldValue::getFloatingPointValue() converts endian each time...

    When calling getFloatingPointValue multiple times, the octets are 
endian-converted each time.
    Actually we need to make a copy first and then call convertIfRequired().

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pavelpokutnev/qpid trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 4ed0ce9c9b74b136c49735b19efb80489aa495a3
Author: Pavel Pokutnev <[email protected]>
Date:   2015-03-31T15:55:59Z

    QPID-6470: FieldValue::getFloatingPointValue() converts endian each time it 
is called.

----


> FieldValue::getFloatingPointValue() converts endian each time it is called
> --------------------------------------------------------------------------
>
>                 Key: QPID-6470
>                 URL: https://issues.apache.org/jira/browse/QPID-6470
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, C++ Clustering
>    Affects Versions: 0.32, 0.33
>         Environment: Windows 7
>            Reporter: Pavel Pokutnev
>            Assignee: Alan Conway
>            Priority: Critical
>              Labels: easyfix, patch
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> When calling getFloatingPointValue multiple times, the octets are 
> endian-converted each time.
> Actually we need to make a copy first and then call convertIfRequired().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to