> On May 6, 2015, 5:49 p.m., Rafael Schloming wrote: > > proton-c/src/reactor/acceptor.c, line 95 > > <https://reviews.apache.org/r/33902/diff/1/?file=951321#file951321line95> > > > > Any particular reason to make this a weakref?
I initially made it a PN_OBJECT, but that didn't work. The reify function doesn't return a valid class so it segfaults when trying to increment the class ref on setting the record. I assumed ssl domain wasn't intended to be used in that manner, so went with the weakref (i.e. just store the pointer). - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33902/#review82699 ----------------------------------------------------------- On May 6, 2015, 5:37 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33902/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 5:37 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Bugs: PROTON-860 > https://issues.apache.org/jira/browse/PROTON-860 > > > Repository: qpid-proton-git > > > Description > ------- > > Provide function with which an ssl_domain can be associated with an acceptor, > and thus configure ssl on transports of connections accepted by that acceptor. > > > Diffs > ----- > > proton-c/bindings/python/proton/reactor.py 467bb76 > proton-c/include/proton/reactor.h 36ee336 > proton-c/src/reactor/acceptor.c f7202d4 > > Diff: https://reviews.apache.org/r/33902/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
