-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36087/
-----------------------------------------------------------

Review request for qpid and Rafael Schloming.


Bugs: PROTON-927
    https://issues.apache.org/jira/browse/PROTON-927


Repository: qpid-proton-git


Description
-------

This only encodes non-zero times. That means of course that it is not possible 
to send 0 as an explicit value. However that is still in my view an improvement 
on sending 0 regardless. If the distinction between unset and 0 is desired that 
can be handled by a separate issue.


Diffs
-----

  proton-c/src/message/message.c b24a994 
  tests/python/proton_tests/message.py 2f7cb4f 

Diff: https://reviews.apache.org/r/36087/diff/


Testing
-------

Added test to ensure times surive roundtrip. Manually tested the actual encoding


Thanks,

Gordon Sim

Reply via email to