----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36102/#review90119 -----------------------------------------------------------
Ship it! This looks like good code to me. - Andrew Stitcher On July 1, 2015, 6:38 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36102/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 6:38 p.m.) > > > Review request for qpid, Andrew Stitcher and Rafael Schloming. > > > Bugs: PROTON-907 > https://issues.apache.org/jira/browse/PROTON-907 > > > Repository: qpid-proton-git > > > Description > ------- > > Messenger appears only to check readability and writability of the > selectables, not whether they are in the error state (eg. from the socket > hanging up), which results in fragility when errors are encountered as > currently it expects the socket to be both readable and writable in such > cases. > > > Diffs > ----- > > proton-c/src/messenger/messenger.c 9749bf5 > > Diff: https://reviews.apache.org/r/36102/diff/ > > > Testing > ------- > > Passes tests and avoids the busy loop as described in PROTON-907 > > > Thanks, > > Gordon Sim > >
