[
https://issues.apache.org/jira/browse/QPID-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617511#comment-14617511
]
Keith Wall commented on QPID-6624:
----------------------------------
Two comments:
# org.apache.qpid.server.model.port.AmqpPortImpl#getDefaultAmqpSupportedReply
I think, as this is free text user input, it should guard the case where the
string cannot be converted to Protocol (i.e. Protocol.valueOf throws IAE). I
think logging a warning and continuing as if a value hadn't been set at all is
appropriate.
#
org.apache.qpid.server.transport.MultiVersionProtocolEngine#MultiVersionProtocolEngine
I think the guard for an unknown defaultSupportedReply here whilst harmless is
unnecessary (due to the test in having already been performed in AmqpPortImpl).
I'd favour simpler code - a defensive IAE perhaps and no warning.
> [Java Broker] If a port does not support the default protocol reply, it
> should not error but revert to sending the highest supported version
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6624
> URL: https://issues.apache.org/jira/browse/QPID-6624
> Project: Qpid
> Issue Type: Improvement
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 6.0 [Java]
>
>
> Currently a system property
> "qpid.broker_default_supported_protocol_version_reply" can be used to
> override the default behaviour of replying with the highest supported AMQP
> version.
> If, for a given port, this protocol is not supported, then the port becomes
> in error.
> This behvaiour should be changed so that 1) the property becomes a context
> value rather than a system property and 2) if the default reply is not
> supported then a warning is issued on construction, and instead the default
> policy of returning the highest supported version is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
