----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35798/#review92087 -----------------------------------------------------------
proton-c/include/proton/transport.h (line 348) <https://reviews.apache.org/r/35798/#comment146027> Reopening, because the doc still says PN_TIMEOUT and Ken is correct. It is the wrong error. proton-c/src/transport/transport.c (line 2662) <https://reviews.apache.org/r/35798/#comment146028> Wrong error return as above. - Andrew Stitcher On July 17, 2015, 2:39 p.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35798/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 2:39 p.m.) > > > Review request for qpid, Andrew Stitcher and Kenneth Giusti. > > > Repository: qpid-proton-git > > > Description > ------- > > Alter C impl to return error code if we attempt to change local channel_max > after OPEN frame has been sent. Also alter python binding to detect that > error code, and throw exception. This way, the C and Java versions of one of > the test of channel_max functionality have the same behavior. > > > Diffs > ----- > > proton-c/include/proton/error.h c6c7d2e > proton-c/include/proton/transport.h 483f5a9 > proton-c/src/transport/transport.c ff80e21 > tests/python/proton_tests/engine.py 258665d > > Diff: https://reviews.apache.org/r/35798/diff/ > > > Testing > ------- > > ctest -VV --- C and Java > > Please note: This Jira changes the public interface in that it adds #define > PN_OK 0 to the list of possible error return values in error.h > > > Thanks, > > michael goulish > >
