[
https://issues.apache.org/jira/browse/QPID-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709971#comment-14709971
]
Keith Wall commented on QPID-6662:
----------------------------------
Hi Rob
A couple of initial comments on r1697182:
# AbstractBDBMessageStore.StoredBDBMessage#getContent(int, java.nio.ByteBuffer)
does not uphold its contract as offsetInMessage is ignored. Also its
QpidByteBuffers are not disposed.
# AbstractBDBMessageStore#getContent is a dead method
# AbstractBDBMessageStore.StoredBDBMessage#isInMemory should be synchronised.
Volatile now seems superfluous
AbstractBDBMessageStore.StoredBDBMessage#_messageDataRef
# QpidByteBuffer#allocateDirectCollectionFromPool in the case when size <=
maxPooledBufferSize, when not try to service the request from the _cachedBuffer
before allocating a new buffer?
> Use direct byte buffers
> -----------------------
>
> Key: QPID-6662
> URL: https://issues.apache.org/jira/browse/QPID-6662
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Fix For: qpid-java-6.0
>
>
> To improve performance of the Broker, direct ByteBuffers should be passed
> from the transport directly to the store, minimising copying whenever
> possible, and vice versa.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
