[ 
https://issues.apache.org/jira/browse/QPID-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960463#comment-14960463
 ] 

ASF subversion and git services commented on QPID-6283:
-------------------------------------------------------

Commit 1708943 from [~lorenz.quack] in branch 'java/trunk'
[ https://svn.apache.org/r1708943 ]

QPID-6283: [Java Broker] Close possibility for DivByZero in 
FileSystemSizeChecker

Addressed review comments from Keith Wall.
This closes the possibility of a DivByZero in the unlucky case where the store 
gets deleted just before the call to getTotalSpace()

> FileSystemSpaceChecker can generate java.lang.ArithmeticException / by zero
> ---------------------------------------------------------------------------
>
>                 Key: QPID-6283
>                 URL: https://issues.apache.org/jira/browse/QPID-6283
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.31
>            Reporter: Keith Wall
>            Priority: Minor
>
> Whilst testing trunk I ran into the following stack trace being periodically 
> written to the log.
> 2014-12-22 17:58:02,093 WARN  [default2:FileSystemSpaceChecker] 
> (virtualhost.AbstractVirtualHost$FileSystemSpaceChecker) -  throw exception: 
> java.lang.ArithmeticException: / by zero
> java.lang.ArithmeticException: / by zero
>       at 
> org.apache.qpid.server.virtualhost.AbstractVirtualHost$FileSystemSpaceChecker.execute(AbstractVirtualHost.java:1578)
>       at 
> org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:59)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:356)
>       at 
> org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:52)
>       at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>       at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
>       at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
>       at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>       at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to