----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40189/#review106155 -----------------------------------------------------------
Ship it! Ship It! - Gordon Sim On Nov. 11, 2015, 9:03 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40189/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 9:03 p.m.) > > > Review request for qpid, Alan Conway and Gordon Sim. > > > Bugs: qpid-6839 > https://issues.apache.org/jira/browse/qpid-6839 > > > Repository: qpid > > > Description > ------- > > Have a default try: except: block wrapping the I/O thread's run() method. > Pass the exception back up to the selectable (Driver), which will set the > error field on the connection. The main thread will check for the error an > raise it to the application. > > > Diffs > ----- > > trunk/qpid/python/qpid/messaging/driver.py 1710683 > trunk/qpid/python/qpid/selector.py 1710683 > > Diff: https://reviews.apache.org/r/40189/diff/ > > > Testing > ------- > > hacked a delayed raise Exception("test") in the body of the selector's thread. > > > Thanks, > > Kenneth Giusti > >
