----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41456/#review111068 -----------------------------------------------------------
Ship it! Go ahead and commit it. I am going to make some changes but I will do the properties and annotations together when I do, meantime this works. Point me at the relevant interop test code and I'll update it when I get there. I note you just have annotations, I'm trying to figure out if we need separate delivery and message annotations. I don't see anything in the spec that allows you to distinguish them by key only so I suspect we might. - Alan Conway On Dec. 16, 2015, 7:12 p.m., Kim van der Riet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41456/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 7:12 p.m.) > > > Review request for qpid and Alan Conway. > > > Repository: qpid-proton-git > > > Description > ------- > > Qpid-interop-test needs to use annotations in the c++ bindings for JMS > messages which rely upon them for successfully identifying a message type. > This patch is the bare-bones only, there are no comments or tests. > > > Diffs > ----- > > proton-c/bindings/cpp/include/proton/message.hpp 0954b49 > proton-c/bindings/cpp/src/message.cpp dd57606 > > Diff: https://reviews.apache.org/r/41456/diff/ > > > Testing > ------- > > Tested within qpid-interop-test for JMS message tests, works as expected. > > > Thanks, > > Kim van der Riet > >
