[ 
https://issues.apache.org/jira/browse/QPID-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098211#comment-15098211
 ] 

Keith Wall commented on QPID-6979:
----------------------------------

Change looks reasonable to me.

> AttributeValueConverter's Certificate handling code assumes unix line endings
> -----------------------------------------------------------------------------
>
>                 Key: QPID-6979
>                 URL: https://issues.apache.org/jira/browse/QPID-6979
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>            Priority: Minor
>             Fix For: qpid-java-6.0.1, qpid-java-6.1
>
>
> The generic code {{AttributeValueConverter}} is used to instantiate model 
> attributes/model operation parameters of type Certificate.   It has the 
> ability to convert from a PEM format representation to a Certificate, but 
> this has a defect.
> It assumes that unix line endings will be used.  If windows line endings were 
> used, the subsequent call to the certificate factory will fail.
> The following model operation is affected by this problem:
> ManagedPeerCertificateTrustStore#addCertificate()
> The workaround is to convert the input to unix line endings.
> The BEGIN/END certificate parsing code should also be enhanced to fail early 
> if it encounters a BEGIN without a corresponding END.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to