----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43500/#review118919 -----------------------------------------------------------
trunk/qpid/python/qpid/messaging/endpoints.py (line 49) <https://reviews.apache.org/r/43500/#comment180232> I originally called the new method 'set_error_callback()' and forgot to rename the internal member. - Kenneth Giusti On Feb. 11, 2016, 8:29 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43500/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 8:29 p.m.) > > > Review request for qpid and Justin Ross. > > > Bugs: QPID-7053 > https://issues.apache.org/jira/browse/QPID-7053 > > > Repository: qpid > > > Description > ------- > > An application can use the python-qpid client API via a "semi-polled" > approach by leveraging the "message_received" callback registered to a > Session. This allows the app to do other things while waiting for a message > to arrive. However, if an error occurs in the background driver thread, the > app will never be notified. And since a message may never arrive due to the > error, the app can hang. > > This change allows the task to register a callback that is invoked when the > driver thread detects an error. This is in addition to the original behavior > - to raise the error when the app next calls into the API. The intent of the > callback is to cause the app to schedule itself to re-poll the API. > > > Diffs > ----- > > trunk/qpid/python/qpid/messaging/endpoints.py 1726802 > trunk/qpid/python/qpid/tests/messaging/endpoints.py 1726802 > > Diff: https://reviews.apache.org/r/43500/diff/ > > > Testing > ------- > > new tests added for the api > > > Thanks, > > Kenneth Giusti > >
