[
https://issues.apache.org/jira/browse/QPID-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193744#comment-15193744
]
Lorenz Quack commented on QPID-7066:
------------------------------------
regarding 3. I agree it would be preferable to catch this at compile time but
catching it at runtime is surely preferable to not catching it at all, right?
You could argue that you do not want to make the code more complicated to
handle programming errors but the cases are already handled and the problem is
silently ignored. Namely on line
[469|https://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AbstractConfiguredObject.java?view=markup&pathrev=1734964#l469]
and
[474|https://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AbstractConfiguredObject.java?view=markup&pathrev=1734964#l474]
of ACO.
> [Java Broker] Add a validValuePattern attribute to ManagedAttribute
> -------------------------------------------------------------------
>
> Key: QPID-7066
> URL: https://issues.apache.org/jira/browse/QPID-7066
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Priority: Minor
> Fix For: qpid-java-6.1
>
>
> Currently there is no way to convey through meta data that an attribute value
> must conform to a particular pattern (for instance in the case of a hostname
> or ip address).
> Where a managed attribute is of type String, the regex can be used both
> client and server side to validate the input. Client side validation will
> also always need to take into account that it is always legal to insert a
> context variable reference into the value... and where such a context
> injection is present is is effectively impossible to correctly validate on
> the client side.
> For attributes which are of type Collection<String>, List<String> or
> Set<String> the validValuePattern can be taken to be referring to the
> validation applied to each element of the collection.
> The annotation information should also be conveyed through the metadataservlet
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
